Vauxhall Zafira knocking

Vauxhall Zafira

I changed shock as the passenger rear was knocking. It is still knocking and I’ve noticed a burning rubber smell from the same area.